Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix : 테스트 리팩토링 및 로그인 서비스 리팩토링 #96

Merged
merged 1 commit into from
Nov 23, 2022

Conversation

superkkj
Copy link
Contributor

관련된 이슈 번호

요약

  • 테스트 공통적으로 명시적 1L 사용대신 DUMY 로 쓸모없는 데이터라는걸 명시 하거나 랜덤으로 Long값을 줘서 어떤 값이든 테스트 통과
  • 협력 객체 테스트 에 추가

@github-actions
Copy link

Unit Test Results

50 tests   - 2   50 ✔️  - 2   2s ⏱️ -1s
16 suites ±0     0 💤 ±0 
16 files   ±0     0 ±0 

Results for commit 00cba6b. ± Comparison against base commit 0e58b27.

This pull request removes 2 tests.
com.uniqueauction.domain.review.service.ReviewServiceTest ‑ 상품이 없을땐 NOTFOUND EXCEPTION
com.uniqueauction.domain.review.service.ReviewServiceTest ‑ 유저이 없을땐 NOTFOUND EXCEPTION

@superkkj superkkj merged commit 33fa1f8 into develop Nov 23, 2022
@superkkj superkkj deleted the bug/#94-testAddCooperation branch November 23, 2022 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants