Change compile error printing/throwing logic #127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, Chanterelle only throws a compilation error and fails if there is no compiler artifact for the module being compiled. In most cases (e.g., syntax errors, missing dependencies,
pragma solidityvs compiler version mismatch) this is perfectly fine. However, there are certain classes of error which can give a "partial" artifact (i.e., has an ABI, but no bytecode). One such case is when you have more stack variables than the EVM can support. (try declaring 20 localbytes memoryvariables at the start of the case). In this case, there's nothing wrong with the Solidity code per se. The compiler can produce an ABI, source map, etc. for it -- it just can't produce EVM-compatible bytecode for it.What would happen currently is that the errors wouldn't get logged, and you'd get a mysterious "Compiler output lacked an
evmfield". This change improves error logging and causes compilation to fail if any kind of error (i.e., with solidity severity >WARNING) is reported for a module.