Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get rid of Maybe types in Change and TxReceipt when you can #19

Open
martyall opened this issue Aug 2, 2018 · 0 comments
Open

Get rid of Maybe types in Change and TxReceipt when you can #19

martyall opened this issue Aug 2, 2018 · 0 comments

Comments

@martyall
Copy link

martyall commented Aug 2, 2018

Right now the TxReceipt, and Change type have a bunch of maybes to indicate that these transactions possibly haven't been processed yet. Sometimes you know already that they have been processed. I think we should use some kind of dependent types with a singleton argument indicating whether the request is for something known to be processed or not known.

The concrete case this is really biting us is in the event processing. When you're processing events with filters that run to Latest, then you know that if you get a TxHash from some event and look up the receipt that it will have a Just value for all the block metadata. It's annoying to deal with this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant