Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recursive fragment control problem fixed #42

Merged
merged 1 commit into from Jun 21, 2019
Merged

Recursive fragment control problem fixed #42

merged 1 commit into from Jun 21, 2019

Conversation

SinanMtl
Copy link
Contributor

@SinanMtl SinanMtl commented Jun 20, 2019

This PR is fixes recursive fragment name control problem. For example:

Sample query

query {
   checks {
      ...Check
   }
}
fragment Check on Check {
  id
  name
}

fragment CheckNode on Check {
  id
  name
}

collectFragments method controls fragments names with RegExp but RegExp parser searching like this: /\.\.\.Check/. This is wrong matching because search with contain value. Match with two fragments ['Check', 'CheckNode'].

The problem fixes with end of line operator ($). For example: /\.\.\./Check$

@f f merged commit be2b7aa into f:master Jun 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants