fixed macro expansion when crystal spec is run. #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It appears that the Passing the tag names as strings at compile time does fix the problem (and protects against any future changes to keywords), but let me know if you don't think it's the best solution. |
|
Oh, sorry, i haven't seen this PR. Just did the same in #4 and it has been merged. @domgetter my apologies! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
crystal specwas failing to compile due to a name clash of the "select" method. This commit changes the tag names to strings for macro expansion so that spec can compile correctly.Let me know if this is acceptable or you want anything changed.