Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transition breaking changes #72

Closed
kristinademeshchik opened this issue May 27, 2019 · 3 comments
Closed

Transition breaking changes #72

kristinademeshchik opened this issue May 27, 2019 · 3 comments

Comments

@kristinademeshchik
Copy link

kristinademeshchik commented May 27, 2019

Hey!

First of all, I wanna thank you for such a good job you're doing!

The problem I wanna draw your attention to is about transition. After you introduced the transition element our application got broken. So here's the thing, if we send multiple elements as content for v-wait, Vue is complaining about multiple elements inside of transition and asking to use transition-group instead.

We can easily fix it by wrapping content into div, but as long as it's something that pretty hard to debug, you might want to do it on vue-wait side

Thanks!

@f
Copy link
Owner

f commented May 28, 2019 via email

@f
Copy link
Owner

f commented May 28, 2019

Hi I've fixed it and released with v1.4.6. Thank you! Can you please test it and close the issue if it's resolved.

@kristinademeshchik
Copy link
Author

Hi I've fixed it and released with v1.4.6. Thank you! Can you please test it and close the issue if it's resolved.

Wow that was quick 👍
Now it's alright, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants