Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
More UI/accessibility changes (mostly; big commit)
Let's start with: Changes not (directly) related to the BUG menu: * Fixed an issue with [advc.001c]: No GP probabilities had been shown when there was a positive GP rate but no accumulated progress yet. * Bug fixed in the recently merged [dlph.26] (restructured code for triggered declarations of war): Attitude cache was not getting updated when there was just a single declaration of war (no wars triggered). * Added an upper bound for the number of Barbarians placed per unowned tile because Barbarian activity was sometimes too intense on the highest difficulty settings. [advc.300] (Still to be done: When placing Barbarians, take into account where Barbarians have previously been placed or killed. This mechanism is going make sure that Barbarians don't keep coming and coming in large numbers.) * Animals may enter unowned tiles with a resource if that resource requires a tech to be revealed. This should make it impossible to infer hidden resources from the movements of animals. [advc.309] * Default number of Advanced Start points in the Ancient era set to 400 (was 800). 400 is a better default for the SPaH option and not unreasonable for regular Advanced Start. [advc.250b] * Two bugs fixed in BUG's calculateTradeRoutes function (TradeUtil.py). I don't think either of these had any impact in AdvCiv, but they were still bugs. Merged from Dawn of Civilization; Git commit: dguenms/Dawn-of-Civilization@6dbe198 * Freed up some space on the "Active" tab of the Foreign Advisor by removing the leader name headings. [advc.066] * To make the help text shown when hovering over a unit icon more compact, the owner is no longer shown when the unit belongs to the active player. [advc.069] * Colon removed after "Turn" on the game turn display (upper right corner). [advc.002k] * Sevopedia shows icons before category headings only if there is room. In English, almost all headings are sufficiently short, but, in other languages, many are too long (given the AdvCiv font size). [advc.002b] * A few more changes to the shortcuts section of Sevopedia. [advc.004y] As a result of trying to generate some very large maps: * Amended [advc.030] (impassable tiles can separate map areas) to make the computation of areas less memory-intensive. * Fixed a Python crash at game start resulting from [advc.004a] (reworked bulb path utility). In the process, I've exposed CvGlobalContext::IsGraphicsInitialized to Python. I'm keeping it exposed although I'm not using it after all. BUG MENU Tidied up the layout of the entire BUG/K-Mod menu, in part, to match AdvCiv's increased font size [advc.002b], revised or rewrote most of the help texts (some of which were nearly incomprehensible to me) in English and German and made minor changes to the behavior of some of the options, in particular, again, changes to help text (on the actual widgets). Merged a bit of code from BULL, but nothing major; some of that remains to be done (see Tbd. in the manual under change id 004). The one part of BUG that I mostly skipped is the Customizable Domestic Advisor. Improved the handling of invalid data in BUG ini files. Hopefully, this will later result in smooth updates from AdvCiv 0.94 to 0.95. [advc.009d] In the process, I came across a few bugs in the error handling code in BugOptionsTab.py. [advc.001] BUG no longer writes default values and hover text as comments into its ini files. As far as I can tell, this only affects new installations because the comments are only written once when the ini files are created -- which is also why I'm disabling them: they become outdated when the options-related XML files are changed. (And the ini files shouldn't be edited manually anyway, so comments don't make much sense.) [advc.009d] AdvCiv options moved from XML to the BUG menu (enabled by default): * Option to show resource bubbles at the start of a new game moved to the "Map" tab. Also, the option didn't actually work. I think it did work in v0.94 and I don't know how I broke it, but, anyway, it should be fixed now. [advc.004m] * Option to color-code team membership moved to the "Score" tab. Now only works when the option for the Advanced/Tabular layout is also enabled. [advc.155] * Moved the "List Units per Owner" option [advc.061] from the General tab of the BUG menu to the Map tab. [advc.061] Merged from BULL: * Adapted WhipAssist (overflow info on Hurry button) to K-Mod's treatment of excess overflow. Overflow info on the production bar (if enabled) now uses the same (C++) code as WhipAssist; redundant Python code in CvMainInterface.py commented out. [advc.064] Functional changes to BUG options: * Uncoupled the "Show Era" and "Show Era Color" options from the "Just Another Game Clock" option and rearranged the "Clock" tab a bit. Added an option to show the primary view of the clock for a longer or shorter time period than the alternate view. (Also added an option for showing the game era instead of the active player's era, but then changed my mind and hid the new option through BugNJAGCOptionsTab.py.) [advc.067] * Added a dirty-bit for the Tech Advisor screen so that the tech tree gets properly redrawn when era colors are changed. [advc.068] * Some changes to PLE mode/filter button help text to match the terminology of the menu. [advc.069] * PLE help text for unit icons shows only the basic unit help; had previously shown e.g. the unique replacements of the unit and its production cost. Turns to heal now shown on a separate line (was an inscrutable number after the combat strength values). [advc.069] * PLE bugfixes: [advc.001,advc.069] - Movement Highlighter had crashed sometimes (AStarTools.py). - Color changes to unit bars had only been applied after a restart (PlotListEnhancements.py). - Health bars had been shown for civilian units (PLE.py; possibly intended that way). * "Fractional Movement Points" now also affects the help text shown when hovering over a unit icon in the plot list. [advc.069] * Bugs fixed in the Autolog mod (autologEventManager.py): had assumed in a few places that the active player is in slot 0, which isn't usually true in scenarios. I haven't tested the corrections in a scenario, so perhaps there are further issues. [advc.001] Removed BUG options: * "Show Strategy layer" because players can use Ctrl+X for that * "Show Percent Progress" (game clock) because the percentage of elapsed game turns isn't a helpful statistic. * Option for setting the default counting method for Raw Yields * "Pending: Border Expansion" and "Peace" alerts * Dark gray can no longer be selected in BUG's drop-down menus. Orange can be selected instead. * Blinking reminder about the BUG menu shortcut * Start year setting (Autolog); the log always uses game turn and game year now. * "Show Culture Turns", "Commerce Subtotals", "Widescreen" (Tech Advisor) and K-Mod's "Non-Zero Stats Only" are always enabled, no longer optional. [advc.065] Changes to default settings: (applies only to new installations of AdvCiv) * "Improved Info Tab" disabled (tab "Advisors") * Send reminders as popups (was popup AND on-screen message; tab "Alerts") * Show WhipAssist tooltip on the hurry button (previously unavailable; tab "City Screen") * FoodAssist ("Detailed Food Info") enabled (tab "City Screen") * Promotion indicator for unit icons disabled (tab "Unit Icons" tab) These changes are only relevant if one enables other options that remain disabled by default: * Promotion Offset in PLE help text set to 8 in order to match changes to the size of the text pane (was 0; tab "Unit Icons") * Custom Inland Advisor's color-coding disabled (tab "Advisors") * "Health Bars" for unit icons enabled and hidden during combat (tab "Unit Icons") * Don't record reminders through Autolog (tab "Alerts") * Don't record slider positions through Autolog (tab "Autolog") * To reduce the space taken up by the "alternate" info of Advanced Combat Odds: - "Survival Odds" and "Unharmed Odds" are never shown - "Basic Values" are only shown in standard view, not in alternate - "XP Range" never shown, alternate view shows "Unrounded XP" instead
- Loading branch information
