Use latest and greatest tools and libraries #124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kirillzh
commented
Mar 17, 2019
| @@ -20,7 +23,7 @@ | |||
| private RxSharedPreferences rxPreferences; | |||
|
|
|||
| @Before public void setUp() { | |||
| SharedPreferences preferences = getDefaultSharedPreferences(RuntimeEnvironment.application); | |||
| SharedPreferences preferences = getDefaultSharedPreferences(ApplicationProvider.getApplicationContext()); | |||
There was a problem hiding this comment.
RuntimeEnvironment.application is deprecated.
kirillzh
commented
Mar 17, 2019
| @@ -112,7 +113,6 @@ public void onSharedPreferenceChanged(SharedPreferences preferences, String key) | |||
| /** Create a long preference for {@code key}. Default is {@code 0}. */ | |||
| @CheckResult @NonNull | |||
| public Preference<Long> getLong(@NonNull String key) { | |||
| //noinspection UnnecessaryBoxing | |||
There was a problem hiding this comment.
These inspections are redundant.
kirillzh
commented
Mar 17, 2019
| @@ -46,7 +48,7 @@ public void onSharedPreferenceChanged(SharedPreferences preferences, String key) | |||
| }; | |||
|
|
|||
| emitter.setCancellable(new Cancellable() { | |||
| @Override public void cancel() throws Exception { | |||
There was a problem hiding this comment.
Never actually throws.
kirillzh
commented
Mar 17, 2019
| group = GROUP | ||
| version = VERSION_NAME | ||
| plugins { | ||
| id("net.ltgt.errorprone") version "0.7.1" |
There was a problem hiding this comment.
TIL you can do this in Gradle 5.2.1
kirillzh
commented
Mar 17, 2019
| } | ||
| dependencies { | ||
| classpath 'com.android.tools.build:gradle:2.3.0' | ||
| classpath 'me.tatarka:gradle-retrolambda:3.3.0' |
There was a problem hiding this comment.
Retrolambda no longer needed with latest butter knife.
kirillzh
commented
Mar 17, 2019
| distributionBase=GRADLE_USER_HOME | ||
| distributionPath=wrapper/dists | ||
| distributionUrl=https\://services.gradle.org/distributions/gradle-5.2.1-all.zip |
kirillzh
force-pushed
the
update-to-latest-and-greatest
branch
from
9c68434
to
eed66bb
Compare
kirillzh
force-pushed
the
update-to-latest-and-greatest
branch
from
eed66bb
to
c7f84f8
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the library to use latest tools and dependencies