Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for YANKED releases #39

Closed
clragon opened this issue Dec 28, 2022 · 3 comments · Fixed by #44
Closed

Support for YANKED releases #39

clragon opened this issue Dec 28, 2022 · 3 comments · Fixed by #44

Comments

@clragon
Copy link

clragon commented Dec 28, 2022

As of right now, it seems that Cider fails to parse releases which have been YANKED.
The section about YANKED releases on keep a changelog states the following:

image

When running Cider, the following exception is thrown:

> cider log added 'some changes'
Unhandled exception:
FormatException: Invalid date format
2021-11-25 [YANKED]
#0      DateTime.parse (dart:core/date_time.dart:347:7)
#1      _release (package:change/src/parser.dart:53:26)
#2      parseChangelog (package:change/src/parser.dart:28:23)
#3      ChangelogService.read (package:cider/src/service/changelog_service.dart:84:36)
#4      ChangelogService.addUnreleased (package:cider/src/service/changelog_service.dart:57:17)
#5      ChangelogService.install.<anonymous closure> (package:cider/src/service/changelog_service.dart:21:31)
#6      Cider.run (package:cider/src/cider.dart:70:35)
<asynchronous suspension>
@clragon clragon changed the title suppot for YANKED releases support for YANKED releases Dec 28, 2022
@clragon clragon changed the title support for YANKED releases Support for YANKED releases Dec 28, 2022
@clragon
Copy link
Author

clragon commented Dec 28, 2022

While working in this issue, it would probably also be useful to have a command to yank a release.
Perhaps simply cider yank [<version>].

@f3ath
Copy link
Owner

f3ath commented Dec 30, 2022

In YAML, the square brackets denote links. I'm wondering what link you think should [YANKED] be pointing to.

@clragon
Copy link
Author

clragon commented Jan 4, 2023

fantastic question to which I dont exactly have an answer for.
have the keep-a-changelog writers forgotten about it? 🤔
the keep-a-changelog website doesnt have subheaders, so we cant link to the YANKED section...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants