-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implemented the == operator and hashCode. #2
Conversation
@nullrocket thanks for the PR. I have fixed the format check, could you please rebase on |
|
||
expect(thisPointer == thatPointer, true); | ||
expect(emptyPointer == explicitEmptyPointer, true); | ||
expect(thisPointer != differentPointer, true); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I had to bump the dependencies. Would you please rebase once again. Also, let's add some assertions for the .hashCode
:
expect(thisPointer.hashCode == thatPointer.hashCode, true);
expect(emptyPointer.hashCode == explicitEmptyPointer.hashCode, true);
expect(thisPointer.hashCode != differentPointer.hashCode, true);
@nullrocket The CI is failing due to |
Almost there. We just need the coverage #2 (comment) |
No description provided.