Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle readers with CMake #101

Merged
merged 1 commit into from
Dec 13, 2021
Merged

Handle readers with CMake #101

merged 1 commit into from
Dec 13, 2021

Conversation

Meakk
Copy link
Contributor

@Meakk Meakk commented Dec 4, 2021

No description provided.

@Meakk Meakk self-assigned this Dec 4, 2021
@Meakk Meakk marked this pull request as draft December 4, 2021 22:03
@Meakk Meakk force-pushed the cmake-readers branch 3 times, most recently from e2476ac to 8950b27 Compare December 6, 2021 22:48
@mwestphal mwestphal mentioned this pull request Dec 7, 2021
Closed
@mwestphal
Copy link
Contributor

I like this !

@Meakk Meakk force-pushed the cmake-readers branch 2 times, most recently from 309a4b4 to 81b07f6 Compare December 11, 2021 16:57
@Meakk Meakk marked this pull request as ready for review December 11, 2021 16:57
@Meakk Meakk force-pushed the cmake-readers branch 4 times, most recently from 98de168 to 95b8234 Compare December 11, 2021 17:19
@Meakk Meakk force-pushed the cmake-readers branch 12 times, most recently from 74d025f to 9d11e22 Compare December 12, 2021 00:05
@codecov
Copy link

codecov bot commented Dec 12, 2021 •
edited

Codecov Report

Merging #101 (552988a) into master (9d8dc42) will increase coverage by 1.50%.
The diff coverage is 95.45%.

❗ Current head 552988a differs from pull request most recent head 4766e61. Consider uploading reports for the commit 4766e61 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #101      +/-   ##
==========================================
+ Coverage   86.72%   88.22%   +1.50%     
==========================================
  Files          62       67       +5     
  Lines        3600     3619      +19     
==========================================
+ Hits         3122     3193      +71     
+ Misses        478      426      -52
Impacted Files Coverage Δ
src/readers/F3DOBJReader.inl 90.90% <90.90%> (ø)
src/F3DOptions.cxx 97.60% <91.66%> (-0.12%) ⬇️
src/readers/F3DExodusIIReader.inl 100.00% <100.00%> (ø)
src/readers/F3DGLTFReader.inl 100.00% <100.00%> (ø)
src/readers/F3DOCCTReader.inl 100.00% <100.00%> (ø)
src/readers/F3DReader.h 85.71% <100.00%> (+5.71%) ⬆️
src/readers/F3DSTLReader.inl 100.00% <100.00%> (ø)
src/F3DReaderInstantiator.h
src/readers/F3DVRMLReaderReader.h 100.00% <0.00%> (ø)
src/readers/F3DOCCTReader.h 100.00% <0.00%> (ø)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9d8dc42...4766e61. Read the comment docs.

mwestphal
mwestphal requested changes Dec 12, 2021
View reviewed changes
Copy link
Contributor

@mwestphal mwestphal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, some changes needed

@Meakk Meakk force-pushed the cmake-readers branch 7 times, most recently from 30b4ca0 to 1b72917 Compare December 12, 2021 22:14
mwestphal
mwestphal reviewed Dec 13, 2021
View reviewed changes
src/F3DOptions.cxx Outdated Show resolved Hide resolved
mwestphal
mwestphal approved these changes Dec 13, 2021
View reviewed changes
Copy link
Contributor

@mwestphal mwestphal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved after small comments

@Meakk Meakk force-pushed the cmake-readers branch 2 times, most recently from 6487795 to 552988a Compare December 13, 2021 16:47
@Meakk Meakk merged commit 10208ae into f3d-app:master Dec 13, 2021
@Meakk Meakk deleted the cmake-readers branch December 13, 2021 18:21
@mwestphal mwestphal mentioned this pull request Dec 17, 2021
Closed
mwestphalnew pushed a commit to mwestphalnew/f3d that referenced this pull request Feb 10, 2024
@Meakk
Merge pull request f3d-app#101 from Meakk/cmake-readers
9ec1fd5 
Handle readers with CMake
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mwestphal mwestphal mwestphal approved these changes

@jpouderoux jpouderoux Awaiting requested review from jpouderoux

Assignees

@Meakk Meakk

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Meakk @mwestphal @jpouderoux