Introducing f3d::options #191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mwestphal
force-pushed
the
libf3d_API_proto
branch
from
7fddc55
to
590c1d6
Compare
mwestphal
force-pushed
the
libf3d_API_proto
branch
from
c056677
to
690b208
Compare
mwestphal
commented
Jan 9, 2022
mwestphal
commented
Jan 9, 2022
mwestphal
commented
Jan 9, 2022
Meakk
reviewed
Jan 9, 2022
mwestphal
force-pushed
the
libf3d_API_proto
branch
from
690b208
to
2dfcda0
Compare
mwestphal
commented
Jan 10, 2022
Codecov Report
@@ Coverage Diff @@
## master #191 +/- ##
==========================================
+ Coverage 88.26% 88.46% +0.19%
==========================================
Files 71 74 +3
Lines 3733 3840 +107
==========================================
+ Hits 3295 3397 +102
- Misses 438 443 +5
Continue to review full report at Codecov.
|
mwestphal
force-pushed
the
libf3d_API_proto
branch
from
3d91a60
to
3e0d983
Compare
|
@Meakk : please review |
Meakk
reviewed
Jan 11, 2022
Meakk
approved these changes
Jan 12, 2022
mwestphalnew
pushed a commit
to mwestphalnew/f3d
that referenced
this pull request
Feb 10, 2024
Add STEP and IGES file support Closes f3d-app#191 See merge request f3d/f3d!236
mwestphalnew
pushed a commit
to mwestphalnew/f3d
that referenced
this pull request
Feb 10, 2024
In the context of f3d-app#52 , Introduce a first element, f3d::options and start using it when possible without refactoring the whole of F3D for now. TODO in other PRs: - doc - F3DLoader refacto - options names f3d-app#32
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the context of #52 , Introduce a first element, f3d::options and start using it when possible without refactoring the whole of F3D for now.
TODO in other PRs: