Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TX Audio source fails after 1 TX cycle #1731

Closed
artscotty opened this issue Jul 6, 2023 · 7 comments
Closed

TX Audio source fails after 1 TX cycle #1731

artscotty opened this issue Jul 6, 2023 · 7 comments
Assignees
Milestone

Comments

@artscotty
Copy link

artscotty commented Jul 6, 2023

Using the latest release (compiled and binary versions) on MAC OS Ventura and Ubuntu 22.04, my Hack RF looses audio after one perfect transmission. The first time I transmit the Mic audio is excellent and all works, then after the PTT is released, a second TX has no audio or a low noise but no audio. The TONE AUDIO still works and does CW so I assume it's related to audio devices. Has anyone found this or a solution? Thanks Scot

@f4exb
Copy link
Owner

f4exb commented Jul 6, 2023

Issue #1717 has revealed an outstanding design flaw with audio output. Audio input is affected by a similar flaw. The thread handling the audio is the one first starting the audio interface but it should be independent and tied to the audio device. However to implement a similar solution FCD audio handling should be amended to use the Audio Manager.

When you stop/start the Tx device the attached channels are also stopped and started and in this process the "baseband" thread is also stopped and started.

@artscotty
Copy link
Author

Edouard, thank you for your reply. I think you are suggesting I compile the 1717 buffer size() patch ? Also I must install some audio manager like PulseAudio on Mac and use this for audio?

@f4exb
Copy link
Owner

f4exb commented Jul 7, 2023

No this will not change anything, The problem is with the threading model. This has been fixed for audio output but the same flaw is present for audio input (what interests you here). In order to fix this the handling of Funcube Dongles (FCD plugins) has to be fixed first to use the Audio Manager instead of accessing the audio input directly.

EDit: for what concerns pulseaudio on the other hand yes it has to be installed and running for the audio handling to work properly.

@f4exb f4exb self-assigned this Jul 7, 2023
f4exb added a commit that referenced this issue Jul 10, 2023
@f4exb
Copy link
Owner

f4exb commented Jul 10, 2023

Tried only with the TestSink plugin but it did fix the issue.

@artscotty
Copy link
Author

artscotty commented Jul 10, 2023

Ah, I see the changes you made Eduardo. I will download and rebuild from source and let you know. Thank you for this effort,

@f4exb f4exb added this to the v7.15.1 milestone Jul 11, 2023
@artscotty
Copy link
Author

I have compiled and tested this with NFM Modulator and confirm it works as expected. I see no reason other modulators won't work correctly but have not tested those yet. Great job Eduardo!

@f4exb
Copy link
Owner

f4exb commented Jul 11, 2023

deployed in v7.15.1

@f4exb f4exb closed this as completed Jul 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants