Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scope: fix trigger #233

Closed
f4exb opened this issue Oct 24, 2018 · 1 comment
Closed

Scope: fix trigger #233

f4exb opened this issue Oct 24, 2018 · 1 comment
Assignees
@f4exb
Labels
bug
Milestone
v4.2.4

Comments

@f4exb
Copy link
Owner

f4exb commented Oct 24, 2018

The trigger in the scope does not work properly:

  • sometimes it does not react to a valid trigger
  • consecutive traces in memory are not consistent from one to the next

In order to test and prove this a few test patterns are going to be added to the Test source:

  • A binary pattern with a distinctive sync signal and a binary count following
  • A saw tooth pattern

After investigation a fix is available by removing a breaking so called "optimization". This issue is opened just to track changes.
@f4exb f4exb added the bug label Oct 24, 2018
@f4exb f4exb added this to the v4.2.4 milestone Oct 24, 2018
@f4exb f4exb self-assigned this Oct 24, 2018
f4exb added a commit that referenced this issue Oct 27, 2018
@f4exb
Scope: removed breaking optimization thus fixing trigger. Should fix …
02d0a46 
…issue #233
@f4exb
Copy link
Owner Author

f4exb commented Oct 28, 2018

Implemented in v4.2.4

@f4exb f4exb closed this as completed Oct 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@f4exb f4exb

Labels
bug
Projects
None yet
Milestone
v4.2.4
Development

No branches or pull requests
1 participant
@f4exb