Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix fft overlap #1856

Merged
merged 4 commits into from Oct 23, 2023
Merged

Fix fft overlap #1856

merged 4 commits into from Oct 23, 2023

Conversation

das-Iro
Copy link
Contributor

@das-Iro das-Iro commented Oct 23, 2023

The FFT Overlap buffer is not moved properly.

Current binary release:
SDRangel-master
My fix
SDRangel-fix-overlap

Movement of the buffer was double what should have been intended
Added warning to std::copy uses that overlaping copy is undefined
behaviour
@f4exb f4exb merged commit c9a4d54 into f4exb:master Oct 23, 2023
1 of 3 checks passed
@das-Iro das-Iro deleted the fix-fft-overlap branch October 24, 2023 00:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants