Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AM Demod: Add additional modes to specify channel center frequency #1876

Merged
merged 7 commits into from Nov 3, 2023

Conversation

srcejon
Copy link
Collaborator

@srcejon srcejon commented Nov 2, 2023

Currently AM Demod channel center frequency is specified by Δf setting. This PR adds a couple of additional modes, that are selected by a combo box that replaces the Δf label:

image

Δf option uses current behaviour

image

25k - Allows entry of an absolute frequency specified in MHz (as is typical in the airband). This I think has two advantages:

  • No need for any mental arithmetic - you can just type in the ATC frequency you are interested in.
  • The demod stays locked to that frequency, even if the device center frequency changes. (So, you can make adjustments to the device center frequency, without needing to manually retune the demod)

The valuedial only displays 6 digits, as this is typically how airband frequencies are specified / spoken. Although not normally needed with AM, it's still possible to fine tune the demod center frequency to a higher precision than is displayed in the value dial, by dragging the channel marker. The precise frequency is shown at the bottom of the demod, as is currently the case.

By right clicking on the combo box, it's possible to enable snapping (combobox will be highlighted when snapping is enabled). This snaps the channel marker to 25kHz boundaries - this makes it much easier to tune accurately, when you have a wide bandwidth. For example, when bandwidth is >~2M (because you want to see activity across the spectrum), it's quite hard to accurately place the channel marker, as it's quite narrow.

image

8.33k - Allows entry of an 8.33kHz channel number, which is mapped to the appropriate frequency. E.g. 118.910 is mapped to 118,908,333Hz. This also supports snapping, but to 8.333kHz boundaries.

image

Also added a MW option, which allows specifying an absolute frequency in kHz.

Any other use cases you think might be useful?

If you like it, it could be something we added to some of the other demods too (i.e. being able to specify absolute frequencies + support snapping), where appropriate.

Patch also fixes a bug in ValueDialZ, that was preventing using the keyboard to enter the first digit, when m_positiveOnly was true.

@f4exb f4exb merged commit 18458dc into f4exb:master Nov 3, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants