fix SIGSEGV on /sdrangel/deviceset/{deviceSetIndex}/channel/{channelIndex}/settings endpoint #1952
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Editing FrequencyScanner via api fails due to null pointer. Failure happens when swagger generated setValue method is called for complicated/nested structure on the object with is created by constructor, but not initialized by the ::init method. Solution: 1. Call init on newly created object 2. Proactively fix this for all types of settings objects
anton-kotenko
commented
Jan 14, 2024
| channelSettings->getFreeDvModSettings()->fromJsonObject(settingsJsonObject); | ||
| } | ||
| else if (channelSettingsKey == "FreqScannerSettings") | ||
| { | ||
| channelSettings->setFreqScannerSettings(new SWGSDRangel::SWGFreqScannerSettings()); | ||
| channelSettings->getFreqScannerSettings()->init(); |
There was a problem hiding this comment.
Fix the problem itself.
Rest of changes are proactively doing the same for the rest of types, to avoid somebody getting into the same trouble
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Editing FrequencyScanner via api endpoint cases application crash to access by null pointer.
Failure happens when swagger generated setValue method is called for complex/nested structure on the object with is created purely by constructor, but not initialised by the ::init method.
Solution:
This change addresses #1951