Audio optimize & default input/output bugfix #2038
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is this going to prevent new audio devices from being discovered after the initial enumeration? |
As far as Im concerned, there's no way to refresh the device list before. The AudioSelectDialog uses the cached list of AudioDeviceManager, which is not refreshable. |
Yeah. The problem with this, is the audio devices can change at runtime. For example, on Windows when you connect via RDP. It would be useful to be able to refresh the audio devices so audio can be redirected to the client. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes every AudioDeviceInfo singleton to reduce QAudioDeviceInfo calls. frequently calling WASAPI enumerate when startup will lead to crash on my PC... not really know why but it's an optimization anyway.
Fix things about
m_defaultInputStartedandm_defaultOutputStarted. It creates default devices multiple times, causing totally broken and noncontinuous audio.