Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A few updates #2063

Merged
merged 9 commits into from
Apr 10, 2024
Merged

A few updates #2063

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
a77b6f1
Radiosonde: Support uploading to SondeHub. Improve humidity calculati…
srcejon Apr 10, 2024
54713ef
Add DialogPositioner
srcejon Apr 10, 2024
6979117
Fix channel marker
srcejon Apr 10, 2024
5e79f06
Add parent to delegate constructors.
srcejon Apr 10, 2024
d09b3a2
Use aApp application version instead of hardcoded value.
srcejon Apr 10, 2024
2973eff
Preset: Copy and initialise all fields for #2061.
srcejon Apr 10, 2024
c3a1c8d
Fix sdrbench compilation on Windows
srcejon Apr 10, 2024
84960ef
Fix Qt5 compilation
srcejon Apr 10, 2024
4439b43
Remove unneeded file
srcejon Apr 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 3 additions & 0 deletions sdrbench/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ set(sdrbench_SOURCES
test_ft8.cpp
test_callsign.cpp
test_ft8protocols.cpp
../ft8/pack0.cpp
Copy link
Owner

@f4exb f4exb Apr 10, 2024 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should not be added here. It is part of the FT8 library see set(sdrbench_FT8_LIB ft8) above...

Edit: I am wondering why you had an issue with Windows here since the CI/CD with the initial changes went fine: https://github.com/f4exb/sdrangel/actions/runs/8594560974

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have removed it, as doesn't seem to be needed now. I added it when you made the first FT8 related commit - maybe something has changed since then or was just a dodgy build that made it look like it was needed when it wasn't.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes indeed there was a failing build that I corrected in a later commit.

)

set(sdrbench_HEADERS
Expand All @@ -24,13 +25,15 @@ add_library(sdrbench SHARED

include_directories(
${FFTW3F_INCLUDE_DIRS}
${Boost_INCLUDE_DIRS}
${CMAKE_SOURCE_DIR}/exports
${CMAKE_SOURCE_DIR}/sdrbase
${CMAKE_SOURCE_DIR}/logging
${CMAKE_SOURCE_DIR}
)

target_link_libraries(sdrbench
Boost::disable_autolinking
${FFTW3F_LIBRARIES}
Qt::Core
Qt::Gui
Expand Down