Delete ADSBDemod::m_worker after removing sink from DSP #916
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #915.
As described in the issue, during deconstruction of
ADSBDemod
a segmentation fault might occur, ifDSPDeviceSourceEngine
callssink->stop()
afterm_worker
was deleted.This PR fixes the issue by deleting
m_worker
only afterm_deviceAPI->removeChannelSink(this)
is called. This call would otherwise invokesink->stop()
with a brokenm_worker
somewhere down the line.