xc7: tests: reformat tests to use common pcf files #1234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
probot-autolabeler
bot
added
lang-verilog
tmichalak
approved these changes
Dec 16, 2019
acomodi
force-pushed
the
clean-tests-pcf
branch
from
f581775
to
235522d
Compare
Signed-off-by: Alessandro Comodi <acomodi@antmicro.com>
Signed-off-by: Alessandro Comodi <acomodi@antmicro.com>
Signed-off-by: Alessandro Comodi <acomodi@antmicro.com>
Signed-off-by: Alessandro Comodi <acomodi@antmicro.com>
Signed-off-by: Alessandro Comodi <acomodi@antmicro.com>
Some of the tests require specialized pcf files as they use uncommon IOs Signed-off-by: Alessandro Comodi <acomodi@antmicro.com>
acomodi
force-pushed
the
clean-tests-pcf
branch
from
235522d
to
a307a4b
Compare
|
CI went red only on vendor tool tests, with the same failure experienced in other PRs and unrelated to this one. I believe this can be merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Alessandro Comodi acomodi@antmicro.com
This PR is to clean all the xc7 tests, by using the common pcf files.
Some of the tests need a custom
.pcffile, but the majority of them can adopt the one found inxc7/tests/common