-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[xc7] Add clock placer #1237
Merged
Merged
[xc7] Add clock placer #1237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
probot-autolabeler
bot
added
lang-python
Issue uses (or requires) Python language.
type-utils
Issues is related to the scripts inside the repo.
labels
Dec 17, 2019
acomodi
force-pushed
the
build_clocks
branch
2 times, most recently
from
December 19, 2019 14:31
10018a6
to
8a0441c
Compare
I think CI is hitting the same issue as in #1222
|
Signed-off-by: Keith Rothman <537074+litghost@users.noreply.github.com>
Fixes f4pga#1231 Signed-off-by: Keith Rothman <537074+litghost@users.noreply.github.com>
Signed-off-by: Alessandro Comodi <acomodi@antmicro.com>
Signed-off-by: Alessandro Comodi <acomodi@antmicro.com>
Signed-off-by: Alessandro Comodi <acomodi@antmicro.com>
Signed-off-by: Alessandro Comodi <acomodi@antmicro.com>
Signed-off-by: Alessandro Comodi <acomodi@antmicro.com>
Signed-off-by: Alessandro Comodi <acomodi@antmicro.com>
acomodi
force-pushed
the
build_clocks
branch
from
December 23, 2019 11:45
8a0441c
to
1253013
Compare
Signed-off-by: Alessandro Comodi <acomodi@antmicro.com>
@litghost PR went green on all the builds other than I need to reproduce locally in order to be sure about it. Anyway, I believe this can be merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
lang-python
Issue uses (or requires) Python language.
type-utils
Issues is related to the scripts inside the repo.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR builds on top of #1232 as a fix for the python linter was needed.
With prjxray ad prjxray-db updated to latest version, containing the clock_region addition, this PR should now go green.