Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add initial support for PULLTYPE. #1333

Merged
merged 2 commits into from
Feb 25, 2020
Merged

Add initial support for PULLTYPE. #1333

merged 2 commits into from
Feb 25, 2020

Conversation

litghost
Copy link
Contributor

Fixes #1314

@litghost
Add initial support for PULLTYPE.
8b52bdc 
Signed-off-by: Keith Rothman <537074+litghost@users.noreply.github.com>
@probot-autolabeler probot-autolabeler bot added lang-verilog Issue uses (or requires) Verilog language. lang-xml Issues uses (or requires) XML language. type-vpr labels Feb 25, 2020
mithro
mithro requested changes Feb 25, 2020
View reviewed changes
Copy link
Contributor

@mithro mithro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@mkurc-ant
Copy link
Collaborator

@litghost I'm unsure whether the PULLTYPE parameter is recognized by Vivado. If no then please add a comment that it is not as it is done with the IN_TERM parameter.

@litghost
Copy link
Contributor Author

litghost commented Feb 25, 2020 •
edited by unfurl-links bot

Its definitely accepted as a port property (https://github.com/SymbiFlow/prjxray/blob/09ae020ab35ec0bccf82440863481f23c9143a89/fuzzers/030-iob/generate.tcl#L63), unclear about a driver property.

GitHub
Documenting the Xilinx 7-series bit-stream format. - SymbiFlow/prjxray

@litghost
Add comment about properties not support by Vivado.
d81add6 
Signed-off-by: Keith Rothman <537074+litghost@users.noreply.github.com>
@litghost
Copy link
Contributor Author

@litghost I'm unsure whether the PULLTYPE parameter is recognized by Vivado. If no then please add a comment that it is not as it is done with the IN_TERM parameter.

Sure fixed.

@mkurc-ant
Copy link
Collaborator

LGTM

@litghost litghost merged commit 19de798 into f4pga:master Feb 25, 2020
@litghost litghost deleted the add_pulltype_support branch February 25, 2020 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mithro mithro mithro requested changes

@mkurc-ant mkurc-ant Awaiting requested review from mkurc-ant

@acomodi acomodi Awaiting requested review from acomodi

Assignees
No one assigned
Labels
lang-verilog Issue uses (or requires) Verilog language. lang-xml Issues uses (or requires) XML language. type-vpr
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for PULLTYPE
3 participants
@litghost @mkurc-ant @mithro