Fix iobuf inference #1349
Merged
Fix iobuf inference #1349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
probot-autolabeler
bot
added
lang-verilog
mithro
reviewed
Feb 27, 2020
| hierarchy -check -auto-top | ||
|
|
||
| # Start flow after library reading | ||
| synth_xilinx -vpr -flatten -abc9 -nosrl -noclkbuf -nodsp -iopad -run prepare:check |
There was a problem hiding this comment.
Why does this run from prepare to check while the other pathway runs everything?
There was a problem hiding this comment.
Did you read the comment?
There was a problem hiding this comment.
Oh - I think I understand now.
The first couple of lines in this section do the library reading. Then you start from the prepare stage (which is the first stage after library reading)?
mithro
reviewed
Feb 27, 2020
| if { $::env(USE_ROI) == "TRUE" } { | ||
| synth_xilinx -vpr -flatten -abc9 -nosrl -noclkbuf -nodsp | ||
| } else { | ||
| # Read Yosys baseline library first. |
There was a problem hiding this comment.
Why are these not needed for the other pathway?
There was a problem hiding this comment.
What do you mean by "these"?
probot-autolabeler
bot
added
the
lang-python
… ROI-less targets. Signed-off-by: Maciej Kurc <mkurc@antmicro.com>
Signed-off-by: Maciej Kurc <mkurc@antmicro.com>
Signed-off-by: Keith Rothman <537074+litghost@users.noreply.github.com>
Signed-off-by: Keith Rothman <537074+litghost@users.noreply.github.com>
litghost
force-pushed
the
fix_iobuf_inference
branch
2 times, most recently
from
748dd2d
to
8d4be9d
Compare
Signed-off-by: Keith Rothman <537074+litghost@users.noreply.github.com>
litghost
force-pushed
the
fix_iobuf_inference
branch
from
8d4be9d
to
567d5dc
Compare
This was referenced Feb 28, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt to make #1339 pass CI.