Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

install: allow override of VPR options #1482

Merged
merged 1 commit into from
May 15, 2020
Merged

install: allow override of VPR options #1482

merged 1 commit into from
May 15, 2020

Conversation

acomodi
Copy link
Contributor

@acomodi acomodi commented May 12, 2020

Signed-off-by: Alessandro Comodi acomodi@antmicro.com

@acomodi
install: have the VPR options be overridable with an env variable
f8aa52f 
Signed-off-by: Alessandro Comodi <acomodi@antmicro.com>
@acomodi
Copy link
Contributor Author

acomodi commented May 14, 2020

200T vendor tools CI failed with the following:

...
  File "/tmpfs/src/github/symbiflow-arch-defs-presubmit-xc7a200t-vendor/xc/xc7/fasm2bels/make_routes.py", line 583, in expand_sink
    allow_orphan_sinks=allow_orphan_sinks
  File "/tmpfs/src/github/symbiflow-arch-defs-presubmit-xc7a200t-vendor/xc/xc7/fasm2bels/make_routes.py", line 453, in expand_sink
    allow_orphan_sinks=allow_orphan_sinks
  File "/tmpfs/src/github/symbiflow-arch-defs-presubmit-xc7a200t-vendor/xc/xc7/fasm2bels/make_routes.py", line 583, in expand_sink
    allow_orphan_sinks=allow_orphan_sinks
  File "/tmpfs/src/github/symbiflow-arch-defs-presubmit-xc7a200t-vendor/xc/xc7/fasm2bels/make_routes.py", line 453, in expand_sink
    allow_orphan_sinks=allow_orphan_sinks
  File "/tmpfs/src/github/symbiflow-arch-defs-presubmit-xc7a200t-vendor/xc/xc7/fasm2bels/make_routes.py", line 583, in expand_sink
    allow_orphan_sinks=allow_orphan_sinks
  File "/tmpfs/src/github/symbiflow-arch-defs-presubmit-xc7a200t-vendor/xc/xc7/fasm2bels/make_routes.py", line 453, in expand_sink
    allow_orphan_sinks=allow_orphan_sinks
  File "/tmpfs/src/github/symbiflow-arch-defs-presubmit-xc7a200t-vendor/xc/xc7/fasm2bels/make_routes.py", line 583, in expand_sink
    allow_orphan_sinks=allow_orphan_sinks
  File "/tmpfs/src/github/symbiflow-arch-defs-presubmit-xc7a200t-vendor/xc/xc7/fasm2bels/make_routes.py", line 453, in expand_sink
    allow_orphan_sinks=allow_orphan_sinks
  File "/tmpfs/src/github/symbiflow-arch-defs-presubmit-xc7a200t-vendor/xc/xc7/fasm2bels/make_routes.py", line 583, in expand_sink
    allow_orphan_sinks=allow_orphan_sinks
  File "/tmpfs/src/github/symbiflow-arch-defs-presubmit-xc7a200t-vendor/xc/xc7/fasm2bels/make_routes.py", line 453, in expand_sink
    allow_orphan_sinks=allow_orphan_sinks
  File "/tmpfs/src/github/symbiflow-arch-defs-presubmit-xc7a200t-vendor/xc/xc7/fasm2bels/make_routes.py", line 583, in expand_sink
    allow_orphan_sinks=allow_orphan_sinks
  File "/tmpfs/src/github/symbiflow-arch-defs-presubmit-xc7a200t-vendor/xc/xc7/fasm2bels/make_routes.py", line 453, in expand_sink
    allow_orphan_sinks=allow_orphan_sinks
  File "/tmpfs/src/github/symbiflow-arch-defs-presubmit-xc7a200t-vendor/xc/xc7/fasm2bels/make_routes.py", line 583, in expand_sink
    allow_orphan_sinks=allow_orphan_sinks
  File "/tmpfs/src/github/symbiflow-arch-defs-presubmit-xc7a200t-vendor/xc/xc7/fasm2bels/make_routes.py", line 453, in expand_sink
    allow_orphan_sinks=allow_orphan_sinks
  File "/tmpfs/src/github/symbiflow-arch-defs-presubmit-xc7a200t-vendor/xc/xc7/fasm2bels/make_routes.py", line 583, in expand_sink
    allow_orphan_sinks=allow_orphan_sinks
  File "/tmpfs/src/github/symbiflow-arch-defs-presubmit-xc7a200t-vendor/xc/xc7/fasm2bels/make_routes.py", line 453, in expand_sink
    allow_orphan_sinks=allow_orphan_sinks
  File "/tmpfs/src/github/symbiflow-arch-defs-presubmit-xc7a200t-vendor/xc/xc7/fasm2bels/make_routes.py", line 583, in expand_sink
    allow_orphan_sinks=allow_orphan_sinks
  File "/tmpfs/src/github/symbiflow-arch-defs-presubmit-xc7a200t-vendor/xc/xc7/fasm2bels/make_routes.py", line 436, in expand_sink
    sink_node_pkey = get_node_pkey(conn, sink_wire_pkey)
  File "/tmpfs/src/github/symbiflow-arch-defs-presubmit-xc7a200t-vendor/xc/xc7/fasm2bels/connection_db_utils.py", line 60, in get_node_pkey
    c = conn.cursor()
RecursionError: maximum recursion depth exceeded while calling a Python object
...

While XC7 vendor tools failed for known reasons: #1400

@acomodi acomodi requested a review from kgugala May 14, 2020 09:32
@acomodi acomodi changed the title install: have the VPR options be overridable with an env variable install: allow override of VPR options May 15, 2020
@acomodi acomodi requested a review from litghost May 15, 2020 15:15
@litghost litghost merged commit dca8a6d into f4pga:master May 15, 2020
@litghost litghost mentioned this pull request May 15, 2020
Closed
@acomodi acomodi deleted the generic-vpr-parmeters branch July 14, 2020 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kgugala kgugala Awaiting requested review from kgugala

@litghost litghost Awaiting requested review from litghost

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@acomodi @litghost