Allow import scripts to parse huge .net files #1483
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The description of the commit and the PR is rather poor. Please re-write it. These changes are required for OpenTitan, but have nothing to do with OpenTitan per say. |
rw1nkler
changed the title
probot-autolabeler
bot
added
lang-python
rw1nkler
changed the title
rw1nkler
changed the title
This commit changes the architecture importing scripts and allows them to parse huge .net files. Without these changes, libxml fails on using XPath expressions due to the internal memory allocation limit. In that situation, the python wrapper on the libxml library throws misleading error message about incorrect XPath expression. Signed-off-by: Robert Winkler <rwinkler@antmicro.com>
litghost
approved these changes
Jun 23, 2020
|
@HackerFoo Any additional thoughts? |
HackerFoo
approved these changes
Jun 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit changes the architecture importing scripts and allows them to parse huge .net files. Without these changes, libxml fails on using XPath expressions due to the internal memory allocation limit. In that situation, the python wrapper on the libxml library throws misleading error message about incorrect XPath expression.
This changes are required for OpenTitan and are related to #1442 (comment)