Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Define A200T device with limited grid #1505

Merged
merged 2 commits into from
Jul 14, 2020
Merged

Define A200T device with limited grid #1505

merged 2 commits into from
Jul 14, 2020

Conversation

rw1nkler
Copy link
Contributor

This commit defines A200T device with an excluded bottom row with GTP tiles

@rw1nkler rw1nkler changed the title [DNM] Define A200T device with limited grid Define A200T device with limited grid Jun 9, 2020
@rw1nkler rw1nkler requested a review from acomodi June 10, 2020 09:54
acomodi
acomodi suggested changes Jun 10, 2020
View reviewed changes
Copy link
Contributor

@acomodi acomodi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but there should be a test testing that the limited a200t grid works.

Maybe with the picosoc or murax designs.

@mithro
Copy link
Contributor

mithro commented Jun 10, 2020

FYI -- @andrewb1999

@rw1nkler rw1nkler mentioned this pull request Jun 16, 2020
Open
@rw1nkler rw1nkler force-pushed the limit_200T branch 2 times, most recently from 5cef3f3 to d618090 Compare July 8, 2020 14:32
@rw1nkler
Define A200T device with limited grid
869ef75 
This commit defines A200T device with excluded bottom row with GTP tiles

Signed-off-by: Robert Winkler <rwinkler@antmicro.com>
@rw1nkler
Add picosoc test for Nexys Video with limited grid
6dc0824 
Signed-off-by: Robert Winkler <rwinkler@antmicro.com>

Fix picosoc example
@rw1nkler rw1nkler requested a review from acomodi July 14, 2020 11:26
acomodi
acomodi approved these changes Jul 14, 2020
View reviewed changes
Copy link
Contributor

@acomodi acomodi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Looks like XC7200 Vendor CI has ~1 hour more in runtime, but I think that, being it already a full-day running CI, it is acceptable

@litghost litghost merged commit d54ff2a into f4pga:master Jul 14, 2020
@rw1nkler rw1nkler mentioned this pull request Jul 28, 2020
Open
@umarcor umarcor deleted the limit_200T branch March 22, 2022 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acomodi acomodi acomodi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@rw1nkler @mithro @acomodi @litghost @symbiflow-kokoro