-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix clock placement in devices with limited grid #1523
Conversation
PTAL - @tcal-x |
I will try the script on the test where I had to add the workaround LOC constraints. I need to rebuild rr_graph in my sandbox though so it will be a few hours before I have an update. |
This fix may be unrelated to the issue I'm seeing. In any case, I see exactly the same error using the new version of the script, just the line numbers are different. In my case, the script has difficulty placing the PLLE2_ADV if it is not constrained. I'm targeting the full 100T chip. This is the error (line numbers are using the new version from this PR):
|
c5834ff
to
477829c
Compare
9e3f055
to
86a97ec
Compare
I have changed the script to use limited device grid. Additionally, now it is possible to use only top/bottom half of the device. The script does not check if the used resource is available in the given clock domain. (This bug was present before) Because of that, after limiting the device grid, sometimes it tries to place i.e. A universal solution requires rearranging the constraint problem and adding proper checks of variable domains to clocking resources like i.e. PLLs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small change requested
86a97ec
to
b372f13
Compare
b372f13
to
4738ee0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, merge if green
This commit adds the ability to verify if the clock location is available in the FPGA grid before placement. It uses the grid_limit parameter added to the building system. Signed-off-by: Robert Winkler <rwinkler@antmicro.com>
4738ee0
to
d76a0a4
Compare
This commit adds the ability to verify if the clock location is available in the FPGA grid before placement. It uses architecture XML for the verification.
Resolves #1517