Filter NULL tiles in synth tile map to vpr coord #1549
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andrew Butt <andrewb1999@gmail.com>
probot-autolabeler
bot
added
lang-python
litghost
reviewed
Jun 25, 2020
Signed-off-by: Andrew Butt <andrewb1999@gmail.com>
litghost
reviewed
Jun 25, 2020
Signed-off-by: Andrew Butt <andrewb1999@gmail.com>
andrewb1999
force-pushed
the
filter-null-tiles-map-to-vpr
branch
from
0140a71
to
203268c
Compare
|
Does this PR allow you to define synth IO's where you want (excepting #1550)? |
Just double checked, and no, it looks like this version does not fix all issues I was having. Going to try figuring out why next and will update. |
|
Messed up the table join. Fixing now. |
Signed-off-by: Andrew Butt <andrewb1999@gmail.com>
|
@litghost Why did the iCE40 check fail? To me it looks like a random fail. Don't think my changes should affect iCE40 at all. |
Looks like a temporary network disruption. |
litghost
approved these changes
Jun 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Andrew Butt andrewb1999@gmail.com
Filters NULL tile types when mapping synth tiles to vpr coordinates. Fixes #1538