Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci/check-status: set-output name=skip #1742

Merged
merged 1 commit into from
Nov 1, 2020
Merged

Conversation

umarcor
Copy link
Contributor

@umarcor umarcor commented Nov 1, 2020

Close #1741

This is a small enhancement to #1719. Currently, if step 'Check status' fails, the CI run is reported as a failure. This PR sets an output variable (skip) instead. That variable is used as the if condition in all the remaining steps. As a result, CI runs will all be green, unless there is some issue with any of the steps after the first one.

@umarcor umarcor force-pushed the ci/skip branch 3 times, most recently from 78c6dbf to 793fd1f Compare November 1, 2020 04:33
Signed-off-by: umarcor <unai.martinezcorral@ehu.eus>
@umarcor
Copy link
Contributor Author

umarcor commented Nov 1, 2020

@mithro this PR fixes #1741.

Copy link
Contributor

@mithro mithro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

- name: Set up Python
if: steps.check.outputs.skip != 'true'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is no way to wrap all the remaining steps in the if?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately, I don't think so: https://stackoverflow.com/questions/60589373/how-to-force-to-exit-in-github-actions-step

It would be possible to define two jobs (instead of one job with multiple steps). However, then we'd need to pass some parameters from one job to another. I think that'd be too contrived...

@mithro mithro merged commit 2a8e22f into f4pga:master Nov 1, 2020
@umarcor umarcor deleted the ci/skip branch November 2, 2020 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Github action 'checkstatus.yml' fails while status pending
2 participants