Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ANTLR4 dependencies for fasm. #1880

Closed
wants to merge 3 commits into from

Conversation

HackerFoo
Copy link
Contributor

No description provided.

Signed-off-by: Dusty DeWeese <dustin.deweese@gmail.com>
@probot-autolabeler probot-autolabeler bot added the type-infra Issues related to infra like travis. label Dec 14, 2020
@litghost
Copy link
Contributor

========================================
Host install packages
----------------------------------------
Reading package lists...
Building dependency tree...
Reading state information...
E: Unable to locate package libantlr4-runtime-dev

Signed-off-by: Dusty DeWeese <dustin.deweese@gmail.com>
Signed-off-by: Dusty DeWeese <dustin.deweese@gmail.com>
@litghost
Copy link
Contributor

litghost commented Dec 15, 2020

I don't believe building the antlr4 runtime within the arch-defs CI is the right approach here, especially given the fact that 4 other repos will need to do the same thing. I think using a PPA to get a package or adding the dep to the litex hub conda misc are better approaches. @mithro, thoughts?

@HackerFoo
Copy link
Contributor Author

This is a temporary fix until we have a proper package. It doesn't take long to build.

@litghost
Copy link
Contributor

litghost commented Dec 15, 2020

This is a temporary fix until we have a proper package. It doesn't take long to build.

You would have to add this temporary fix to 5 build systems, so even if it doesn't take a long time, it seems like a bad approach.

@HackerFoo
Copy link
Contributor Author

I think this is a better solution: chipsalliance/fasm#41

@HackerFoo HackerFoo closed this Dec 17, 2020
@HackerFoo
Copy link
Contributor Author

Superseded by chipsalliance/fasm#41

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
third-party type-infra Issues related to infra like travis.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants