install: resolve symlinks before packaging #1883
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
probot-autolabeler
bot
added
the
type-utils
HackerFoo
approved these changes
Dec 15, 2020
litghost
reviewed
Dec 15, 2020
common/cmake/devices.cmake
Outdated
| @@ -1470,7 +1470,7 @@ function(ADD_FPGA_TARGET) | |||
| append_file_dependency(VPR_DEPS ${ADD_FPGA_TARGET_INPUT_SDC_FILE}) | |||
| get_file_location(SDC_LOCATION ${ADD_FPGA_TARGET_INPUT_SDC_FILE}) | |||
| set(SDC_ARG --sdc_file ${SDC_LOCATION}) | |||
| set(SDC_FILE ${SDC_LOCATION}) | |||
There was a problem hiding this comment.
This will not work generally speaking. If the SDC is generated, this will break.
There was a problem hiding this comment.
This is in the if branch where the SDC is manually written. The case in which the SDC is auto-generated, the actual generated SDC is taken instead: https://github.com/SymbiFlow/symbiflow-arch-defs/blob/7183cb5e59d50955686c12e4b800a55fafd1fae5/common/cmake/devices.cmake#L1461-L1467
There was a problem hiding this comment.
Even in that cases, the user can provide a generated SDC, e.g.:
add_custom_target(
OUTPUT my_generated.sdc
COMMAND ... > my_generated.sdc
)
add_file_target(FILE my_generated.sdc GENERATED)
add_fpga_target(
...
SDC_FILE my_generated.sdc
)
The new code will break in this case.
There was a problem hiding this comment.
I have changed approach and now the symlinks are resolved before packaging tests into the tarball
Signed-off-by: Alessandro Comodi <acomodi@antmicro.com>
acomodi
force-pushed
the
fix-sdc-install
branch
from
f176716
to
6a04938
Compare
acomodi
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Alessandro Comodi acomodi@antmicro.com
Fixes #1882