-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Populate all parts #1562
Populate all parts #1562
Conversation
bb69054
to
21b0f2d
Compare
Looks like there is some issue with directories on Kintex / Zynq? |
21b0f2d
to
e305d8f
Compare
zynq was my fault. The kintex is because of a non-existing entry in |
@dnltz - I sent you an invite to collaborate on the SymbiFlow project and PrjXRay repo. If you access then hopefully Kokoro will run automatically on your pull requests without needing another person to force the run. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review in
e305d8f
to
e90c888
Compare
e90c888
to
4b12637
Compare
267a30b
to
e090369
Compare
Build failure:
|
e090369
to
e5c58d2
Compare
This step generates all static part information files. Signed-off-by: Daniel Schultz <d.schultz@phytec.de>
These files are now autogenerated and not needed to be deployed to the repo. Signed-off-by: Daniel Schultz <d.schultz@phytec.de>
Signed-off-by: Daniel Schultz <d.schultz@phytec.de>
Signed-off-by: Daniel Schultz <d.schultz@phytec.de>
Signed-off-by: Daniel Schultz <d.schultz@phytec.de>
Signed-off-by: Daniel Schultz <d.schultz@phytec.de>
183d3dd
to
3b472bd
Compare
Yeah, we have a failure :)
because this PR has a lot of changes and normal PRs should not have such a mount of changed lines. Will take a look into the Artix und Zynq issues now. |
So the artix7 failure arose from:
Nothing you did should've caused that change, but it might just be bad luck. Something to try is change https://github.com/SymbiFlow/prjxray/blob/c202abb8a1a89837c9246163f3288a2c1505aedb/fuzzers/025-bram-config/Makefile#L10 |
c17222a
to
2317716
Compare
@litghost - Increasing N to 20 did not help. Should I just open an issue? |
Ya, sure. |
Another option to just add a bit blacklist for this bit. |
So the bad solution is:
A quick search on https://github.com/SymbiFlow/prjxray-db/blob/master/artix7/segbits_bram_l.db shows that no bits are in frame 0, so we probably could just add a frame 0 exclusion, e.g.:
|
2317716
to
59e9e68
Compare
Ah thanks for that hint :) |
59e9e68
to
3fef01c
Compare
Add an exclusion for frame 0 because this does not contain any bits and the database checks fails. Signed-off-by: Daniel Schultz <d.schultz@phytec.de>
3fef01c
to
772c428
Compare
@litghost - Checks were successful today. |
Great work. New prjxray-db should be updated tommorow or early next week. |
These changes allow to easily generate all part information during a full db run.
closes #1476