Non-canonical sorting for bit2fasm #616
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Keith Rothman <537074+litghost@users.noreply.github.com>
Signed-off-by: Keith Rothman <537074+litghost@users.noreply.github.com>
litghost
changed the title
mithro
approved these changes
Feb 7, 2019
Signed-off-by: Keith Rothman <537074+litghost@users.noreply.github.com>
mithro
reviewed
Feb 7, 2019
Makefile
Outdated
| @@ -7,7 +7,7 @@ env: | |||
| $(IN_ENV) pip install -r requirements.txt | |||
| $(IN_ENV) pip install -r docs/requirements.txt | |||
| ln -sf $(PWD)/prjxray env/lib/python3.*/site-packages/ | |||
| ln -sf $(PWD)/third_party/fasm/fasm.py env/lib/python3.*/site-packages/ | |||
| ln -sf $(PWD)/third_party/fasm/ env/lib/python3.*/site-packages/ | |||
There was a problem hiding this comment.
Lets merge this, but we should probably be using something like $(IN_ENV) pip install --develop third_party/fasm.
There was a problem hiding this comment.
It still is not passing, different symptom, similiar failure:
==================================== ERRORS ====================================
______________________ ERROR collecting utils/bit2fasm.py ______________________
utils/bit2fasm.py:8: in <module>
import fasm.output
E ModuleNotFoundError: No module named 'fasm.output'
generated xml file: /home/travis/build/SymbiFlow/prjxray/build/py_test_results.xml
!!!!!!!!!!!!!!!!!!! Interrupted: 1 errors during collection !!!!!!!!!!!!!!!!!!!!
=========================== 1 error in 0.50 seconds ============================
make: *** [test-py] Error 2
The command "make test-py" exited with 2.
Signed-off-by: Keith Rothman <537074+litghost@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.