Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Component | LeafletMap: Configurable inner label color #156

Merged
merged 4 commits into from Mar 27, 2023
Merged

Component | LeafletMap: Configurable inner label color #156

merged 4 commits into from Mar 27, 2023

Conversation

rokotyan
Copy link
Contributor

@rokotyan rokotyan commented Mar 8, 2023 •
edited

This PR adds support for central labels color #155

  • Adding pointLabelColor and clusterLabelColor config properties;
  • Adding new CSS variables:
    --vis-map-cluster-inner-label-text-color-dark: #5b5f6d;
    --vis-map-cluster-inner-label-text-color-light: #fff;

    --vis-map-point-inner-label-text-color-dark: #5b5f6d;
    --vis-map-point-inner-label-text-color-light: #fff;

    --vis-map-point-bottom-label-text-color: #5b5f6d;
  • Updated Angular wrapper;
  • New dev app example: image
  • Updated docs: SCR-20230317-npob SCR-20230317-npqx

@rokotyan rokotyan marked this pull request as draft March 8, 2023 15:12
@rokotyan rokotyan force-pushed the feature/leaflet-map-configurable-inner-label-color branch from 2de38f7 to fadfcd9 Compare March 8, 2023 21:13
@rokotyan rokotyan force-pushed the feature/leaflet-map-configurable-inner-label-color branch from 1b3c739 to f7650fa Compare March 16, 2023 23:22
@rokotyan rokotyan force-pushed the feature/leaflet-map-configurable-inner-label-color branch from f7650fa to 47f8d14 Compare March 17, 2023 21:48
@rokotyan rokotyan requested a review from reb-dev March 17, 2023 22:37
@rokotyan rokotyan added the enhancement New feature or request label Mar 17, 2023
@rokotyan rokotyan added this to the Release v1.1.0 milestone Mar 17, 2023
@rokotyan
Copy link
Contributor Author

@reb-dev This is ready for review

@rokotyan rokotyan marked this pull request as ready for review March 20, 2023 20:54
reb-dev
reb-dev approved these changes Mar 27, 2023
View reviewed changes
Copy link
Collaborator

@reb-dev reb-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, looks good.

@rokotyan rokotyan merged commit 826550c into main Mar 27, 2023
1 check passed
@rokotyan rokotyan mentioned this pull request Apr 19, 2023
Merged
@rokotyan rokotyan deleted the feature/leaflet-map-configurable-inner-label-color branch May 22, 2023 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reb-dev reb-dev reb-dev approved these changes

Assignees

@reb-dev reb-dev

Labels
enhancement New feature or request
Projects
None yet
Milestone
Release v1.1.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rokotyan @reb-dev