Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Container | Core, Single: Setting SVG size in render() #174

Merged
merged 3 commits into from Apr 4, 2023

Conversation

rokotyan
Copy link
Contributor

@rokotyan rokotyan commented Mar 31, 2023

Setting SVG size in render() to avoid unnecessary rendering caused by ResizedObserve, that also interrupted active transitions causing some of the components look "stuck".

Before

image

image

After

image

image

#173

Setting SVG size in `render()` to avoid unnecessary rendering caused by ResizedObserve (see inline comments for more details)

#173
@rokotyan rokotyan added the fix Bug fix label Mar 31, 2023
@rokotyan rokotyan requested a review from reb-dev April 3, 2023 15:58
@rokotyan rokotyan added this to the Release v1.1.0 milestone Apr 3, 2023
@rokotyan rokotyan marked this pull request as ready for review April 3, 2023 15:58
Copy link
Collaborator

@reb-dev reb-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rokotyan Looks good except I'm getting console errors when opening the sankey dev example:
Screen Shot 2023-04-03 at 11 34 25 AM

@rokotyan
Copy link
Contributor Author

rokotyan commented Apr 4, 2023

@rokotyan Looks good except I'm getting console errors when opening the sankey dev example

@reb-dev Thanks for reporting! It allowed me to find a few more rendering issues. Fixed in the latest commits.

@rokotyan rokotyan merged commit 31a34ea into main Apr 4, 2023
1 check passed
@rokotyan rokotyan mentioned this pull request Apr 19, 2023
@rokotyan rokotyan deleted the fix/container-size branch May 22, 2023 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants