Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

@unovis/svelte: Update component lifecycles to prevent DOM related errors #216

Merged
merged 2 commits into from Jun 1, 2023
Merged

@unovis/svelte: Update component lifecycles to prevent DOM related errors #216

merged 2 commits into from Jun 1, 2023

Conversation

reb-dev
Copy link
Collaborator

@reb-dev reb-dev commented May 30, 2023

@reb-dev reb-dev requested a review from rokotyan May 31, 2023 19:29
@rokotyan
Copy link
Contributor

@reb-dev I've been testing you PR with SvelteKit and found that there's one more error that was introduced with my recent ResizeObserver changes:

unovis/packages/ts/src/utils/resize-observer.ts

Line 2 in 6dcb913

export const ResizeObserver = window.ResizeObserver || ResizeObserverPolyfill

To fix it we'll just need to replace window with globalThis. Can you please add this change to this PR?

@reb-dev
Copy link
Collaborator Author

reb-dev commented Jun 1, 2023

@rokotyan

To fix it we'll just need to replace window with globalThis. Can you please add this change to this PR?

Done!

@rokotyan rokotyan merged commit b8c7a19 into main Jun 1, 2023
1 check passed
@rokotyan rokotyan mentioned this pull request Jun 27, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rokotyan rokotyan rokotyan approved these changes

Assignees

@rokotyan rokotyan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@reb-dev @rokotyan