Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core Component and Tooltip event handling tweaks #330

Merged
merged 3 commits into from
Feb 6, 2024

Conversation

rokotyan
Copy link
Contributor

This PR tweaks the behavior of the core component and the tooltip related to events:

  • Core | Component | Events: Check if the callback exists before execution
  • Component | Tooltip: Allowing triggers to be undefined or null
  • Component | Tooltip: If the container is body, don't change its position style because it can have unwanted effect

@reb-dev reb-dev self-assigned this Feb 5, 2024
@reb-dev reb-dev self-requested a review February 5, 2024 20:09
Copy link
Collaborator

@reb-dev reb-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@TasoOneAsia TasoOneAsia added the cla-signed Authors have signed the F5 contributor license agreement label Feb 5, 2024
@rokotyan
Copy link
Contributor Author

rokotyan commented Feb 6, 2024

@reb-dev Great, feel free to merge when you're ready. I won't be able to do it myself.

@reb-dev reb-dev merged commit bfb5321 into f5:main Feb 6, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed Authors have signed the F5 contributor license agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants