Unovis | Angular: Fix Stackblitz #369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my attempt to fix StackBlitz for Angular (issue).
One issue i've noticed was
platform-browser-dynamicwas not being imported. I'm not sure if there's a specific reason to use that, if not, based on this article, I think we could just useplatform-browserinstead. And to simplify things, since angular hasstandalonecomponent now, I think we could just make this a standalone component and avoidNgModuleall together.These updates are based on a working example from @reb-dev (thanks).
Again, I'm very new to the project, so if I missed something, please let me know.