Skip to content

Website | Add new composite chart section and dual axis chart#383

Merged
lee00678 merged 2 commits into
mainfrom
qian/dual-axis-chart-gallery
May 14, 2024
Merged

Website | Add new composite chart section and dual axis chart#383
lee00678 merged 2 commits into
mainfrom
qian/dual-axis-chart-gallery

Conversation

@lee00678

@lee00678 lee00678 commented May 8, 2024

Copy link
Copy Markdown
Collaborator
  • Adding a new section for composite chart. (With more examples coming)
  • Add an example for dual axis chart.

I ported over the one example in dev. Used generated data. Since it's pretty controversial in terms of whether/when people should use it, I figure we simply demo the way to do it, so users know it's a possibility.

dual-axis-chart

@lee00678 lee00678 requested a review from reb-dev May 8, 2024 19:49
@rokotyan

rokotyan commented May 9, 2024

Copy link
Copy Markdown
Contributor

@lee00678 Great, thanks!

I think we should add to the description some brief text and references about pros and cons of using dual axis charts. Datawrapper has a great blog post on the subject: https://blog.datawrapper.de/dualaxis/

@rokotyan

rokotyan commented May 9, 2024

Copy link
Copy Markdown
Contributor

Also, I don't really like the style of the chart I created (I think there's too much red), but maybe it will help scare people away from using two-axis charts 😄

@lee00678

lee00678 commented May 9, 2024

Copy link
Copy Markdown
Collaborator Author

Also, I don't really like the style of the chart I created (I think there's too much red), but maybe it will help scare people away from using two-axis charts 😄

I'm happy to change it to bright orange 🔶 to make it more scary.

Flip blue and red?

@rokotyan

rokotyan commented May 9, 2024

Copy link
Copy Markdown
Contributor

@lee00678 Yes, let's just flip them, thanks!

@lee00678

lee00678 commented May 9, 2024

Copy link
Copy Markdown
Collaborator Author

@lee00678 Great, thanks!

I think we should add to the description some brief text and references about pros and cons of using dual axis charts. Datawrapper has a great blog post on the subject: https://blog.datawrapper.de/dualaxis/

I added the following description, honestly I don't think there are much pros out there. Happy to edit.

This example shows how to create dual axis chart by overlapping two charts. Dual Axis chart maybe good at showing correlations, or compare two datasets with different measurement units. But we suggest using it with caution. Here are some good articles from [Datawrapper](https://blog.datawrapper.de/dualaxis/) and [Florish](https://flourish.studio/blog/dual-axis-charts/).

@rokotyan

rokotyan commented May 9, 2024

Copy link
Copy Markdown
Contributor

@lee00678 Nice, I like it, thanks!

@reb-dev reb-dev left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@lee00678

Copy link
Copy Markdown
Collaborator Author

Thanks for the reviews!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants