Skip to content

Commit

Permalink
fix: integer enum type serialization (#112)
Browse files Browse the repository at this point in the history
Use serde repr to serialize and deserialize the integer enum types.

fixes #26
  • Loading branch information
TroyKomodo committed Jun 6, 2024
1 parent 24c4325 commit 2fb9fa8
Show file tree
Hide file tree
Showing 3 changed files with 16 additions and 21 deletions.
12 changes: 12 additions & 0 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,7 @@ thiserror = "1"
typed-builder = "0.10"
url = "2"
uclient = "0.1"
serde_repr = "0.1"

[dependencies.serde]
version = "1"
Expand Down
24 changes: 3 additions & 21 deletions src/collection/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ use std::{convert::TryFrom, sync::Arc};

use http::Request;
use maybe_async::maybe_async;
use serde::{de::DeserializeOwned, Deserialize, Deserializer, Serialize};
use serde::{de::DeserializeOwned, Deserialize, Serialize};
use serde_json::json;
use uclient::ClientExt;
use url::Url;
Expand Down Expand Up @@ -806,27 +806,9 @@ fn make_header_from_options(
}
}

#[derive(Debug, Clone, PartialEq, Eq, Copy, Serialize)]
#[derive(Debug, Clone, PartialEq, Eq, Copy, serde_repr::Serialize_repr, serde_repr::Deserialize_repr)]
#[repr(u8)]
pub enum CollectionType {
#[serde(rename = "2")]
Document = 2,
#[serde(rename = "3")]
Edge = 3,
}

impl<'de> Deserialize<'de> for CollectionType {
fn deserialize<D>(deserializer: D) -> Result<Self, D::Error>
where
D: Deserializer<'de>,
{
let value = u8::deserialize(deserializer)?;
match value {
2 => Ok(CollectionType::Document),
3 => Ok(CollectionType::Edge),
_ => Err(serde::de::Error::custom(
"Undefined behavior. If the crate breaks after an upgrade of ArangoDB, please \
contact the author.",
)),
}
}
}

0 comments on commit 2fb9fa8

Please sign in to comment.