Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support pipeline analyzer #96

Closed
muhammad-davatgar opened this issue Sep 20, 2022 · 1 comment
Closed

support pipeline analyzer #96

muhammad-davatgar opened this issue Sep 20, 2022 · 1 comment

Comments

@muhammad-davatgar
Copy link
Contributor

arangors currently doesn't support creating pipeline analyzers. which are very useful and would be nice to have
i have already implemented it in my own fork so ill just open a pull request. ill give a little explanation about what i have done below. it's my first contribution so i don't know where else i can put it. hope that's ok.

@muhammad-davatgar
Copy link
Contributor Author

muhammad-davatgar commented Sep 20, 2022

i added a new variant to AnalyzerInfo named Pipeline and which takes PipelineAnalyzerPropertiesas its property.
PipelineAnalyzerProperties has a file pipeline which is vector of PipelineAnalyzers. i had to copy AnalyzerInfo and delete name field because pipeline analyzers don't have name field in their sub-analyzers . and sending one(although it still creates the analyzer) results in a 400 response.
you can also run cargo test test_create_and_drop_pipeline_analyzer to test the added feature

fMeow pushed a commit that referenced this issue Sep 21, 2022
* pipeline analyzer added

* stopwords analyzer added
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant