Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User Management #110

Merged
merged 3 commits into from
Aug 25, 2023
Merged

User Management #110

merged 3 commits into from
Aug 25, 2023

Conversation

sharwinbobde
Copy link
Contributor

Hello,
Here is my contribution 🙏🏽
addresses issue #109 and listed milestone 1.0.x

@sharwinbobde
Copy link
Contributor Author

it is my first contribution here, so I have only implemented CRUD operations for now. Please tell me if its in compliance with the standards and then I will proceed to implement the user-database operations (/_api/user/{user}/database/{dbname})

@fMeow
Copy link
Owner

fMeow commented Aug 23, 2023

Thanks so much. Looks good to me.

@fMeow
Copy link
Owner

fMeow commented Aug 23, 2023

The rustfmt stage failed. Please run cargo fmt and add a new commit to make CI happy.

@sharwinbobde
Copy link
Contributor Author

Hello, Here is the implementation for the remaining endpoints.
I chose not to implement the DELETE endpoints for database and collection access-level modification, because PUT is specific enough.

@fMeow
Copy link
Owner

fMeow commented Aug 25, 2023

Looks good to me. I would merge this PR and publish a new patch version.

@fMeow fMeow closed this Aug 25, 2023
@fMeow fMeow reopened this Aug 25, 2023
@fMeow fMeow merged commit 283d715 into fMeow:main Aug 25, 2023
5 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants