Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Rustls features #81

Closed
wants to merge 5 commits into from
Closed

Fix Rustls features #81

wants to merge 5 commits into from

Conversation

ManevilleF
Copy link
Contributor

@ManevilleF ManevilleF commented Sep 21, 2021 •
edited

It appears the connection module doesn't export any Connection type for both features:

  • reqwest_async_rustls
  • reqwest_blocking_rustls

Additional changes:

  • maybe_async::test conditions for blocking code updated
  • Removed failing assert! in tests, it is failing since ArangoDB 3.8 and I haven't figured out why the revision field changed
  • Fixed a link issue with rustdoc
  • Fixed async conditions in examples
  • Removed empty main functions from examples

Also, should I remove the outdated rustls example?

Closes #82
Should close #79

@ManevilleF ManevilleF marked this pull request as ready for review September 21, 2021 15:40
This was referenced Sep 21, 2021
Open
Open
@ManevilleF ManevilleF closed this Oct 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

rustls features don't work Unit test failing on AqlQueryBuilder
1 participant
@ManevilleF