Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added ICNNA to snirf supporting software list #139

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

forihuelaespina
Copy link

Added ICNNA to snirf supporting software list

Added ICNNA to snirf supporting software list
@Horschig
Copy link
Collaborator

@forihuelaespina can you please add forihuelaespina to https://github.com/fNIRS/snirf/blob/master/.github/workflows/wordlist.txt ? Thanks!

@dboas
Copy link
Collaborator

dboas commented Mar 28, 2024

@forihuelaespina
can you make the change to the wordlist so that your pull request passes the spell check. This pull request is in limbo until you do that.

@samuelpowell
Copy link
Collaborator

@forihuelaespina please could you update as requested by @dboas then we will get this merged?

@forihuelaespina
Copy link
Author

With my apologies for the delay. This has now been attended.

@samuelpowell
Copy link
Collaborator

samuelpowell commented Apr 18, 2024

@forihuelaespina unsure why this is failing, but there is extraneous whitespace at the end of your addition to the wordlist. Could you update (and just in case, leave e.g. a trailing newline if one was present on master).

Disregard above. I do not know why this is not passing, any ideas?

@Horschig
Copy link
Collaborator

@forihuelaespina unsure why this is failing, but there is extraneous whitespace at the end of your addition to the wordlist. Could you update (and just in case, leave e.g. a trailing newline if one was present on master).

Disregard above. I do not know why this is not passing, any ideas?

Not sure, the trailing white space is the only thing that would come to mind also.

@forihuelaespina
Copy link
Author

I've now removed the trailing space but left the trailing lines just in case. Whether this is what is preventing the update or not, I do not know.

@samuelpowell samuelpowell enabled auto-merge (squash) April 18, 2024 14:53
@samuelpowell
Copy link
Collaborator

@Horschig can you approve review also?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants