Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove @typescript-eslint/experimental-utils #65

Merged
merged 5 commits into from
Nov 10, 2022

Conversation

fa93hws
Copy link
Owner

@fa93hws fa93hws commented Nov 5, 2022

fixes #64
cc @stropho

@codecov
Copy link

codecov bot commented Nov 6, 2022

Codecov Report

Merging #65 (d742188) into master (776fdac) will not change coverage.
The diff coverage is 100.00%.

❗ Current head d742188 differs from pull request most recent head bf85d47. Consider uploading reports for the commit bf85d47 to get more accurate results

@@            Coverage Diff            @@
##            master       #65   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            7         7           
  Lines          118       118           
  Branches        19        19           
=========================================
  Hits           118       118           
Flag Coverage Δ
unittests 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/mark-result.ts 100.00% <ø> (ø)
src/index.ts 100.00% <100.00%> (ø)
src/position-helper.ts 100.00% <100.00%> (ø)
src/rule-runner.ts 100.00% <100.00%> (ø)
src/utils/testing-rules/assert-config.ts 100.00% <100.00%> (ø)
src/utils/testing-rules/create-rule.ts 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link

@stropho stropho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks a lot

},
"peerDependencies": {
"eslint": ">5.0.0"
"@typescript-eslint/utils": ">4.0.0"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

imho, this should appear also in devDependencies. The package users (library consumers) don't care, but might be handy for local development ;)

Copy link

@stropho stropho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@fa93hws fa93hws merged commit dc6aea0 into master Nov 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@typescript-eslint/experimental-utils dependency
2 participants