array_merge of $options in Database::__construct() loses keys.

[rhys-mcguckin]

According to http://php.net/manual/en/function.array-merge.php, the keys that are being set in https://github.com/FaaPz/Slim-PDO/blob/master/src/PDO/Database.php under the __construct function, are being renumbered, so they are being passed to the parent constructor using the incorrect values.

I'd suggest using "$options += array(default options)" statement instead, which preserves the numeric keys, while allowing what I believe is the intended behaviour here.

[FaaPz]

You're right! Just released v1.9.2 (f557397) with the fix included... 😁

[cristianp6]

Hi @FaaPz !
First of all thanks for this usefull library ;-)

Anyway, construct still loses given $options, indeed merge on line 31 should be:
$options = $options + $this->getDefaultOptions();
or, as suggested by rhys-mcguckin, in a shorten way
$options += $this->getDefaultOptions();

Am I right?