You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I'd suggest using "$options += array(default options)" statement instead, which preserves the numeric keys, while allowing what I believe is the intended behaviour here.
The text was updated successfully, but these errors were encountered:
Hi @FaaPz !
First of all thanks for this usefull library ;-)
Anyway, construct still loses given $options, indeed merge on line 31 should be: $options = $options + $this->getDefaultOptions();
or, as suggested by rhys-mcguckin, in a shorten way $options += $this->getDefaultOptions();
According to http://php.net/manual/en/function.array-merge.php, the keys that are being set in https://github.com/FaaPz/Slim-PDO/blob/master/src/PDO/Database.php under the __construct function, are being renumbered, so they are being passed to the parent constructor using the incorrect values.
I'd suggest using "$options += array(default options)" statement instead, which preserves the numeric keys, while allowing what I believe is the intended behaviour here.
The text was updated successfully, but these errors were encountered: