Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace use of RapidJSON with protobuf JSON utilities #167

Closed
Shillaker opened this issue Oct 28, 2021 · 0 comments · Fixed by #302
Closed

Replace use of RapidJSON with protobuf JSON utilities #167

Shillaker opened this issue Oct 28, 2021 · 0 comments · Fixed by #302

Comments

@Shillaker
Copy link
Collaborator

Shillaker commented Oct 28, 2021

The use of RapidJSON to manually parse JSON is now no longer necessary, and instead we can use protobuf tools to convert JSON coming from a client directly into a protobuf object.

This file contains our only use of RapidJSON, so working upwards from there we should be able to completely remove the dependency. To make it a clean change, we could of course keep the existing functions but just change their implementation to use the protobuf equivalent.

Breaking changes to clients

Various clients rely on the current JSON field naming scheme (cpp client, Python client, and all the experiments), so if we can preserve this that would also reduce the impact of this change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant