Pass non-const messages to executors #109
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've thought about it and I'll walk back my comments in faasm/faasm#428 ; Faabric should actually pass non-const
Message
s toExecutors
as it's reasonable to assume they will need to modify them (e.g. to set output data).The change is just to remove the
const
from a few of theExecutor
interface functions, then update all the implementations we find in this repo.