Initialise point-to-point mappings from scheduler output (groundwork) #160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shillaker
changed the title
Shillaker
changed the title
Shillaker
changed the title
Shillaker
commented
Oct 22, 2021
| @@ -6,6 +6,8 @@ | |||
| #include <faabric/util/locks.h> | |||
There was a problem hiding this comment.
This diff is pretty messed up as I've removed a lot of the interface for this class. Best to look at full version:
https://github.com/faasm/faabric/blob/scheduling-decisions/src/transport/PointToPointBroker.cpp
Shillaker
commented
Oct 22, 2021
| formatByteArrayToIntString(kickOffData), | ||
| formatByteArrayToIntString(expectedKickOffData)); | ||
| return 1; | ||
| } |
There was a problem hiding this comment.
This sort of point-to-point initialisation is done transparently now.
Shillaker
commented
Oct 22, 2021
| FAIL(); | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
These tests were covering the old PointToPointBroker API which has been simplified (and is tested below).
csegarragonz
approved these changes
Oct 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment, scheduling and point-to-point messaging are seen as two separate things, and the function/ executor doing the scheduling has to ensure that the point-to-point mappings are set up independently. It also means that the scheduled functions have to wait for confirmation from the master before performing any point-to-point messaging, as they cannot ensure the mappings have been set up when they start executing (this is equivalent to the barrier we use before executing MPI functions).
Ideally the point-to-point mappings would be set up transparently when a group of functions is scheduled, and the downstream functions wouldn't have to manually synchronise before doing point-to-point messaging.
The full implementation of this transparent point-to-point setup will be completed with the introduction of function groups in #141, but this PR contains a lot of the groundwork for it (to avoid bloating the other one).
Changes:
SchedulingDecisionobject, which captures all the metadata from the scheduling, and is returned by the scheduler after scheduling has completed.PointToPointBrokerto only accept aSchedulingDecisionobject as the input to set up the mapping (as it will only be the scheduler doing this setup in future).sendMessagethat checks if the mappings for that app are available on the current host, and does a blocking wait if not.SchedulingDecisionobject returned fromcallFunctions.Note that I've put the
SchedulingDecisioninfaabric::utilas it's essentially just a struct used for passing data around, and things consuming it don't need a full dependency on theschedulingmodule.